Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#5199 Set the current page on the top menu - OMP 3.4 #1505

Open
wants to merge 2 commits into
base: stable-3_4_0
Choose a base branch
from

Conversation

israelcefrin
Copy link

This PR fixes this issue pkp/pkp-lib#5199:

  • Add class "active" to visually highlight the current menu item
  • Add aria-current="page" to screen readers announce the current page from the na menu
  • Increase menu items padding-top and padding-bottom when using mobile screen (24px height minimum recommended by WCAG 2.2)

I've ported the check page function from Pragma(OJS) theme adjusting the function to add the class and the aria attribute while checking for submenus.

@israelcefrin israelcefrin force-pushed the i5199_set_the_current_page_on_the_top_menu branch from d2738ce to 0488910 Compare January 26, 2024 02:53
@jonasraoni jonasraoni force-pushed the i5199_set_the_current_page_on_the_top_menu branch from 3c50efe to 8bffcd4 Compare January 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants